Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove migrate English.lproj deprecated warning #872

Merged
merged 1 commit into from
May 27, 2020

Conversation

jcesarmobile
Copy link
Member

those changes are done by Xcode on the template if selecting "migrate English.lproj (deprecated)" warning

@jcesarmobile jcesarmobile requested a review from erisu May 27, 2020 10:33
@codecov-commenter
Copy link

Codecov Report

Merging #872 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1676     1676           
=======================================
  Hits         1247     1247           
  Misses        429      429           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54fed1...57766e6. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu erisu merged commit ec5db54 into apache:master May 27, 2020
@jcesarmobile jcesarmobile deleted the remove-english branch May 27, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants