Revert "Don't pre-fill orientation" #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erisu
approved these changes
Jun 17, 2020
This reverts commit fb49478.
dpogue
force-pushed
the
revert-615-fix/orientation
branch
from
05512e5 to
f89539e
Compare
jcesarmobile
requested review from
jcesarmobile
and removed request for
jcesarmobile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #615
These defaults actually match the default values from a standard blank iOS app generated by Xcode, and the lack of these defaults are causing unexpected behaviour (#899).
To restrict the orientation, use the
Orientationpreference in config.xml.