Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update npm dependencies #976

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Aug 28, 2020

Platforms affected

iOS

Motivation and Context

Routine dependency updates

Description

Update npm dependencies.

Fixes some audit warnings about lodash, and also ensure we are using
cordova-common 4.0.2 with the fix for Info.plist files.

Testing

Waiting for CI to build and run this.

dpogue added 2 commits August 28, 2020 12:46
Fixes some audit warnings about lodash, and also ensure we are using
cordova-common 4.0.2 with the fix for Info.plist files.
This needs to be investigated later, but I'll leave it for now so I can
try to get a patch release out.
@dpogue
Copy link
Member Author

dpogue commented Aug 28, 2020

Jasmine 3.6.0 causes a bunch of test failures with TypeError: target is not a constructor. Going to leave it as 3.5.0 for now.

@dpogue dpogue merged commit 9eda0f4 into apache:master Aug 28, 2020
@dpogue dpogue deleted the dependency-updates branch August 28, 2020 20:46
dpogue added a commit that referenced this pull request Aug 28, 2020
* chore: Update npm dependencies

Fixes some audit warnings about lodash, and also ensure we are using
cordova-common 4.0.2 with the fix for Info.plist files.

* Don't update Jasmine because it breaks tests

This needs to be investigated later, but I'll leave it for now so I can
try to get a patch release out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant