Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Electron Support #188

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Add Electron Support #188

merged 1 commit into from
Feb 22, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Feb 22, 2019

Platforms affected

none

Motivation and Context

Add Support to Build for Electron

Description

  • Added Electron path to package.json
  • Added Electron compile to Gruntfile.js

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from dpogue February 22, 2019 05:34
Copy link

@knight9999 knight9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is necessary update.
Fine.

@erisu erisu merged commit 2d56086 into apache:master Feb 22, 2019
@erisu erisu deleted the electron-support branch April 4, 2019 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants