Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop build/test support for Node.js 6 #190

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

raphinesse
Copy link
Contributor

Some npm packages, including some of our build/test dependencies have
begun dropping support for Node.js 6 in their latest versions. To
facilitate dependency updates, we remove support for Node.js 6 here.

This package is usually not built and tested on our user's machines,
but is instead bundled with the platforms by us. Thus, this change
should not be considered a breaking change.

@raphinesse raphinesse requested a review from erisu April 3, 2019 08:34
Some npm packages, including some of our build/test dependencies have
begun dropping support for Node.js 6 in their latest versions. To
facilitate dependency updates, we remove support for Node.js 6 here.

This package is usually not built and tested on our user's machines,
but is instead bundled with the platforms by us. Thus, this change
should not be considered a breaking change.
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we have not officially announced a deprecation plan for Node 6. I am OK with this.
As you said, This package is usually not built and tested on our user's machines (end-users)

👍

@raphinesse raphinesse merged commit 76fd9d8 into apache:master Apr 3, 2019
@raphinesse raphinesse deleted the drop-node6 branch April 3, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants