fix(glob): fs.glob uses native path separator which broke module IDs #283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have added Node 22 to CI before doing the
fs.globSync
change 🤦🏼♂️Platforms affected
Windows
Motivation and Context
So
fs.glob
returns paths using the system path separator, whilefast-glob
andglobby
always return POSIX-style paths. Since we use this value for module IDs (i.e.,cordova.require('some/module/path')
) we need to ensure the IDs use POSIX-style separators.NodeJS apparently still doesn't have an API to fix this beyond just doing string replacements.
Description
Force module IDs to always use POSIX-style path separators.
Testing
Ran tests in CI with logging to reproduce and fix the bug.
Checklist