CB-5696 find ios project directory using the xcode project file #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| config_files = config_files.filter(function (val) { | ||
| return !(/^build\//.test(val)) && !(/\/www\/config.xml$/.test(val)); | ||
| }); | ||
| var xcBuildConfiguration = xcodeproj['hash']['project']['objects']['XCBuildConfiguration']; |
There was a problem hiding this comment.
You can use directly the pbxXCBuildConfigurationSection() function that is available on the prototype: https://github.com/alunny/node-xcode/blob/master/lib/pbxProject.js#L394
Mitko-Kerezov
force-pushed
the
CB-5696
branch
from
dab1930
to
f9dce31
Compare
Add unit tests for future reassurance Fix incorrect name "ChildApp" in .pbxproj files to "SampleApp" Related to https://issues.apache.org/jira/browse/CB-5696
Mitko-Kerezov
force-pushed
the
CB-5696
branch
from
f9dce31
to
f93217c
Compare
|
Hey @shazron can you take a look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit tests for future reassurance
Fix incorrect name "ChildApp" in .pbxproj files to "SampleApp"
Related to https://issues.apache.org/jira/browse/CB-5696