Misc spec fixes/cleanup #649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
force-pushed
the
misc-spec-fixes
branch
from
888a8f6 to
adffaa4
Compare
raphinesse
force-pushed
the
misc-spec-fixes
branch
from
d068fbe to
6eed5ae
Compare
Codecov Report
@@ Coverage Diff @@
## master #649 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 57 57
Lines 3015 3015
=======================================
Hits 2436 2436
Misses 579 579
Continue to review full report at Codecov.
|
Tests 012 and 014 were both seemingly trying to test the same thing and both failing to do so. I replaced them with a fixed Test 012.
raphinesse
force-pushed
the
misc-spec-fixes
branch
from
6eed5ae to
6183f68
Compare
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly revolving around ESLint stuff. This is a diverse assortment, but I would like to avoid to create a PR for every one of these changes. If some are controversial, I'd be happy to pull them out for now, though.