Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more stuff #666

Merged
merged 11 commits into from
Aug 28, 2018
Merged

Remove more stuff #666

merged 11 commits into from
Aug 28, 2018

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Aug 27, 2018

For determining unused code, I searched across all apache/cordova repos

@codecov-io
Copy link

codecov-io commented Aug 27, 2018

Codecov Report

Merging #666 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
- Coverage   80.79%   80.68%   -0.12%     
==========================================
  Files          57       52       -5     
  Lines        3015     2930      -85     
==========================================
- Hits         2436     2364      -72     
+ Misses        579      566      -13
Impacted Files Coverage Δ
src/hooks/HooksRunner.js 84.82% <ø> (+0.47%) ⬆️
src/cordova/cordova.js 66.66% <ø> (-8.34%) ⬇️
src/cordova/prepare.js 97.14% <ø> (-0.08%) ⬇️
src/plugman/uninstall.js 93.63% <ø> (+2.77%) ⬆️
src/plugman/install.js 91.72% <ø> (+1.65%) ⬆️
src/plugman/plugman.js 7.69% <ø> (-5.36%) ⬇️
src/cordova/util.js 83.88% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39abbe0...e9d2087. Read the comment docs.

@raphinesse
Copy link
Contributor Author

.@dpogue Thanks for the review/approval. I will merge this as soon as CI has re-run.

@raphinesse raphinesse merged commit 7c40e49 into apache:master Aug 28, 2018
@raphinesse raphinesse deleted the remove-more-stuff branch August 28, 2018 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants