-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove more stuff #666
Merged
Merged
Remove more stuff #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
force-pushed
the
remove-more-stuff
branch
from
August 27, 2018 09:28
4b2e91e
to
a409c0e
Compare
Codecov Report
@@ Coverage Diff @@
## master #666 +/- ##
==========================================
- Coverage 80.79% 80.68% -0.12%
==========================================
Files 57 52 -5
Lines 3015 2930 -85
==========================================
- Hits 2436 2364 -72
+ Misses 579 566 -13
Continue to review full report at Codecov.
|
3 tasks
Seems this had been moved to cordova-common
raphinesse
force-pushed
the
remove-more-stuff
branch
from
August 28, 2018 13:31
a409c0e
to
e9d2087
Compare
dpogue
approved these changes
Aug 28, 2018
.@dpogue Thanks for the review/approval. I will merge this as soon as CI has re-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For determining unused code, I searched across all
apache/cordova
repos