refactor: remove stub interface to cordova-create
#820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead, `cordova-create` should be depended on directly by its users. Follow-up to apache/cordova-cli#489 BREAKING CHANGE: removes export `cordova.create`
Codecov Report
@@ Coverage Diff @@
## master #820 +/- ##
==========================================
+ Coverage 89.27% 89.28% +0.01%
==========================================
Files 47 46 -1
Lines 2172 2166 -6
==========================================
- Hits 1939 1934 -5
+ Misses 233 232 -1
Continue to review full report at Codecov.
|
erisu
approved these changes
Nov 11, 2019
raphinesse
added a commit
that referenced
this pull request
Jul 1, 2020
This should have been part of #820
raphinesse
added a commit
that referenced
this pull request
Jul 2, 2020
This should have been part of #820
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #820 +/- ##
==========================================
+ Coverage 89.27% 89.28% +0.01%
==========================================
Files 47 46 -1
Lines 2172 2166 -6
==========================================
- Hits 1939 1934 -5
+ Misses 233 232 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead,
cordova-createshould be depended on directly by its users.Follow-up to apache/cordova-cli#489
BREAKING CHANGE: removes export
cordova.create