Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build property by targetname #106

Merged
merged 3 commits into from
Apr 9, 2020
Merged

Update build property by targetname #106

merged 3 commits into from
Apr 9, 2020

Conversation

NiklasMerz
Copy link
Member

Only possible with the help of @erisu

This PR adds a new parameter to make it possible to only update a specific target.

This is needed for apache/cordova-ios#538.

Related:

#79 Another PR for xcode

@NiklasMerz NiklasMerz added this to the 3.0 milestone Apr 7, 2020
@NiklasMerz
Copy link
Member Author

I finally managed to write tests for this this. If it fits in we could get this and #79 in for the next ios release.

Let me know if the tests make sense.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@erisu erisu merged commit 511a06f into apache:master Apr 9, 2020
@l3ender
Copy link
Contributor

l3ender commented Apr 13, 2020

@NiklasMerz, I see this was added to the 3.0 release. Is this change by itself breaking? Or are the breaking changes in 3.0 related to other parts of the release? Thanks!

@timbru31
Copy link
Member

This change alone shouldn't be breaking. We've considered #94 and #79 as breaking changes semver wise.

@NiklasMerz NiklasMerz deleted the feature/update-build-property-by-targetname branch July 28, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants