-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: switch travis ci for github actions #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree that Github actions is more convenient than Travis which can be slow and time out.
Code looks good to me,too. Do we want to add package-lock.json
to Git with this PR? Is this intentional? I still don't know if adding package-lock is a good idea for librariees like this one.
Per NPMJS:
Anyone using this library should install it though |
Thank you. I learned something new! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, too
@NiklasMerz - FYI: apache/cordova#4 |
package-lock.json
to usenpm cit
nyc
code coverage dependencycodecov
serviceOverall goal, unify services used across repo. Travis CI is a slow service during peak hours and its something that is unbearable. This is caused by the resources of the service is shared across all Apache projects. If people have limited time to review and/or do releases, waiting for tests should not be a bottleneck.