Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose Target and use it for logging & uninstall #5

Closed
wants to merge 1 commit into from
Closed

Choose Target and use it for logging & uninstall #5

wants to merge 1 commit into from

Conversation

sarangan12
Copy link
Contributor

@omefire @riknoll @rakatyal Can you please review this PR?

riknoll
riknoll reviewed May 6, 2016
View reviewed changes
lib/ParamedicAppUninstall.js
}

ParamedicAppUninstall.prototype.uninstallAppIOS = function(targetObj, app) {
//No activity necessary at this point. App is automatically unistalled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: unistalled => uninstalled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@riknoll
Copy link
Contributor

riknoll commented May 11, 2016

LGTM. @sarangan12 what's up with the Travis build?

@sarangan12
Copy link
Contributor Author

https://issues.apache.org/jira/browse/CB-11255

@asfgit asfgit closed this in 9ce2935 May 18, 2016
@sgrebnov
Copy link
Member

sgrebnov commented May 19, 2016 •
edited
Loading

This broke --justBuild option as this should not be applied.

Example trace output:
https://ci.appveyor.com/project/sgrebnov/azure-activedirectory-library-for-cordova/build/1.0.7

cordova-paramedic: Choosing Target for Windows
cordova-paramedic: Running command: cordova run --list --emulator
cordova-paramedic: running command cordova build windows --target No devices found matching the specified criteria. --archs=arm -- --appx=8.1-phone 
Error: Unknown platforms: devices, found, matching, the, specified, criteria.

cordova-paramedic: unable to run tests; command log is available above
Collecting logs for the devices.

@nikhilkh
Copy link

@sgrebnov Can you please send a PR for a fix for this?

@sgrebnov
Copy link
Member

Done: #6

janpio pushed a commit that referenced this pull request Nov 24, 2018
@johanlantz @janpio
Ensure output is posted to console after child process finishes (#5)
4997a3e
janpio pushed a commit that referenced this pull request Nov 24, 2018
@johanlantz @janpio
Ensure output is posted to console after child process finishes (#5)
40abb42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sarangan12 @riknoll @sgrebnov @nikhilkh