Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure output is posted to console after child process finishes #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure output is posted to console after child process finishes #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/paramedic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,18 @@ ParamedicRunner.prototype.runLocalTests = function () {
if (self.config.getPlatformId() !== util.BROWSER) {
return execPromise(command);
}
runProcess = cp.exec(command, function () {
// a precaution not to try to kill some other process
// We do not wait for the child process to finish, server connects when deployed and ready.
runProcess = cp.exec(command, (error, stdout, stderr) => {
if (error) {
// This won't show up until the process completes:
console.log('[ERROR]: Running cordova run failed');

console.log(stdout);
console.log(stderr);
reject(error);
}
console.log(stdout);
console.log(stderr);
runProcess = null;
});
})
Expand Down