feat(ios): Keep the metadata of image, add GPS when take picture from Camera (CB-6708) #230
Conversation
|
test passed |
| @@ -240,13 +240,9 @@ - (void)alertView:(UIAlertView *)alertView clickedButtonAtIndex:(NSInteger)butto | |||
|
|
|||
| - (void)repositionPopover:(CDVInvokedUrlCommand*)command | |||
| { | |||
| if (([[self pickerController] pickerPopoverController] != nil) && [[[self pickerController] pickerPopoverController] isPopoverVisible]) { | |||
| NSDictionary* options = [command argumentAtIndex:0 withDefault:nil]; | |||
There was a problem hiding this comment.
Hi.
Thanks for the PR.
I think you forked you repo before this changes were made and didn't sync before sending your PR, but this code is important to fix another bug.
Can you make sure that your fork is in sync with the latest code on this repo and then send the PR with just the relevant code to fix the issue?
There was a problem hiding this comment.
Hi.
I have sync code to my forks.
|
ICLA has been signed and re submitted to secretary@apache.org. |
|
Hi! Is it merged with master branch? |
|
Is there any update on getting this merged? |
|
friendly ping @dhrumil162 😄 |
|
What is needed to merge this? |
|
There is a conflict in a file now unfortunately. Could you take care of this @lxbyes? Thanks. |
|
any update on this merge please? |
janpio
changed the title
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist