CB-13307: (Android) Fixed issue when unable to load image with mime t… #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype "image/*", and failing to recognize new contentprovider uri authority.
|
I'm cool with it, but I can't even test if this fixes it because I don't even have the ability to pull from Google Photos when I test it. Did that break on Android P? |
|
I have not done any testing on Android P, and do not have access to it. |
|
Hey @DavidBriglio , there seems to be a merge conflict now. Could you maybe fix this? Thanks. |
Merge original repo into fork
|
And another rebase/merge from |
also accept terms for android sdk `android-27`
|
@janpio Tests are now passing! |
probably caused by merge and rebase
|
Jippieh! I removed some unwanted changes to README that somehow made their way into this via merge/rebase. Now "only" waiting for review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ype "image/*", and failing to recognize new contentprovider uri authority.
Platforms affected
Android
What does this PR do?
Allows for image mimetype "image/*" to be accepted as a valid image.
Allows for google photos uri authority ".contentprovider" to be recognized.
What testing has been done on this change?
When running "npm test" results in "invalid config loglevel='notice'".
When running "npm run test-build" results in "missing script: test-build".
Manual testing has been done on Android 8.0 Google Pixel with cordova cli 6.5.0.