CB-13781: (android) Fixed permissions request on Android 8 to save a … #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…photo into the photo album
|
Not sure why iOS failed, since you didn't touch it, but yeah, this looks good to me and I can repo the bug, so I'll merge this in once I test locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…photo into the photo album
Platforms affected
Android
What does this PR do?
It fixes a issue managing permissions on Android 8 when a photo wants to be saved into the photo album.
The plugin is requesting both WRITE and READ permissions, if they are not accepted yet, before taking a photo by the device camera.
What testing has been done on this change?
The changed has been tested on multiple Android devices both with Android 8 and with Android 7-.
As for example
Checklist