Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) overlay view supporting to show the indicated image titled "overl… #715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hajunho
Copy link

@hajunho hajunho commented Mar 21, 2021

…ayImage.png"

Platforms affected

Nothing.

Motivation and Context

Another Cordova Plug-in uses a Cordova camera also. Overlay view is the primary API of the iOS platform. I think the overlay view function is inserted into the Cordova primary function to follow the trend of native Apps.

None.

Description

Testing

I have several projects used by over 1000+ users of the company titled Daelim. I've tested with this plugin and tested the hello-world program. As you can see from the codes, It is just for the iOS user to overlay view. I think it starts at the codes to guide. Will uses very usefully later on. I think I can update & test every month for this.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ayImage.png"
@timbru31
Copy link
Member

timbru31 commented Mar 22, 2021

Thanks for your PR - could you please elaborate what it does? It's not quite clear to me what addition it has or bug it fixes. Besides that, it would be good to keep the different platform all in sync, i.e., adding an Android implementation, too. (if suitable & feasible)

@hajunho
Copy link
Author

hajunho commented Mar 23, 2021

Thanks for your PR - could you please elaborate what it does? It's not quite clear to me what addition it has or bug it fixes. Besides that, it would be good to keep the different platform all in sync, i.e., adding an Android implementation, too. (if suitable & feasible)

Thank you for reviewing. I didn't touch the established codes. It's just an indirection layer. As you already know, the overlay view can be used for the additional view to putting the picture after the function "taking the picture". We use this for the watermark for that(I had adjusted Alpha value 0.38). Platform-specific codes are not applicable, I know. but I agree with your opinion to add this function to Android also. These codes have to be changed after using the additional function by the native developer. What I didn't decide things is what options have to be inserted. i.e Alpha value, images, location, size, watermark or location, or timestamp options. Those are very big considering but I or somebody have to do I think. These are base codes for that and no errors(No called basically)

@IllusionVK
Copy link

IllusionVK commented Mar 12, 2022

Hey @hajunho! I have read all the comments on this, but i'm still not clear on what it does. Do your changes allow for the use of this? https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619113-cameraoverlayview

And what exactly is that used for? when I looked it seems it can allow custom buttons ? or maybe overlay on preview ? (see some examples below)

Based on what this says, a developer can disable the default controls and then provide their own? https://stackoverflow.com/a/23887452/636479

@hajunho
Copy link
Author

hajunho commented Mar 12, 2022 via email

@IllusionVK
Copy link

IllusionVK commented Mar 17, 2022

Hi @hajunho, so could you share the link to the other repo to help some other people ?

And could you help us to understand what cameraoverlayview is used for, and is the link that I included the correct one ?(https://developer.apple.com/documentation/uikit/uiimagepickercontroller/1619113-cameraoverlayview)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants