Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: updates Node.js versions #120

Merged
merged 1 commit into from
Mar 26, 2020
Merged

ci: updates Node.js versions #120

merged 1 commit into from
Mar 26, 2020

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Mar 25, 2020 •
edited
Loading

Ref to apache/cordova#79

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu
Copy link
Member

erisu commented Mar 26, 2020

I don't think we want to upgrade to VS2019.

apache/cordova-windows#327

@timbru31
Copy link
Member Author

Uhh, I’ve forgotten about this change by Microsoft :(

@timbru31 timbru31 marked this pull request as ready for review March 26, 2020 11:16
@timbru31 timbru31 changed the title build(ci): updates Node.js and base image versions build(ci): updates Node.js versions Mar 26, 2020
@timbru31 timbru31 force-pushed the feat/updates-node-in-ci branch from 65662ad to 45600f9 Compare March 26, 2020 12:59
@timbru31 timbru31 changed the title build(ci): updates Node.js versions ci: updates Node.js versions Mar 26, 2020
@timbru31 timbru31 force-pushed the feat/updates-node-in-ci branch from 45600f9 to da383a6 Compare March 26, 2020 12:59
@timbru31 timbru31 mentioned this pull request Mar 26, 2020
Merged
5 tasks
@erisu erisu mentioned this pull request Mar 26, 2020
Closed
44 tasks
@timbru31 timbru31 merged commit 171f53c into master Mar 26, 2020
@timbru31 timbru31 deleted the feat/updates-node-in-ci branch March 26, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timbru31 @erisu