Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update gh-action's workflow #198

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

erisu
Copy link
Member

@erisu erisu commented May 13, 2024

Platforms affected

n/a

Motivation and Context

Update CI Workflow

Description

Updated:

  • Dependencies
  • Android test matrix
  • Use linux & enable KVM
  • Use node 20

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

- android: 12L
android-api: 32

- android: 13
android-api: 33

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth adding API 34 now that the API 34 support has been merged?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it later.

Needs to be added, tested, confirmed on paramedic first before adding to plugins. I usually try and set paramedic CI first as its used as the source of truth for all plugin CI workflows.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and added API 34 since paramedic has been updated since. Also updated the JDK to 17.

@erisu erisu merged commit 655ba2c into apache:master May 31, 2024
13 of 15 checks passed
@erisu erisu deleted the ci/update-workflow branch May 31, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants