Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)!: set platform requirement >= 7.0.0 #200

Merged
merged 2 commits into from
May 31, 2024
Merged

fix(android)!: set platform requirement >= 7.0.0 #200

merged 2 commits into from
May 31, 2024

Conversation

erisu
Copy link
Member

@erisu erisu commented May 14, 2024 •
edited
Loading

Platforms affected

android

Motivation and Context

Added platform engine requirement for cordova-android because of recent changes applied by #62 .

Description

Set cordova-android >= 7.0.0.

Testing

n/a

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from jcesarmobile May 14, 2024 09:04
@jcesarmobile
Copy link
Member

I managed to get the user commit
#201

jcesarmobile
jcesarmobile requested changes May 14, 2024
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

engines also need to be set in the plugin.xml

https://github.com/apache/cordova-plugin-device/blob/master/plugin.xml#L34

@erisu erisu changed the title fix(android)!: access Context through webView.getContext() fix(android)!: set platform requirement >= 7.0.0 May 15, 2024
@erisu erisu merged commit 0c4f367 into apache:master May 31, 2024
3 of 9 checks passed
@erisu erisu deleted the fix/use-context branch May 31, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcesarmobile jcesarmobile jcesarmobile approved these changes

@breautek breautek breautek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erisu @jcesarmobile @breautek