Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Directory Reader bug and fix proxy for electron #387

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix Directory Reader bug and fix proxy for electron #387

wants to merge 8 commits into from

Conversation

rohitagre
Copy link

@rohitagre rohitagre commented Apr 8, 2020 •
edited
Loading

Platforms affected

Motivation and Context

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@zorn-v
Copy link

zorn-v commented Apr 11, 2020 •
edited
Loading

Bad news for you - this repo is abandoned
Check #371

@capc0
Copy link

capc0 commented Dec 15, 2020

@Jammer99 you have this plugin working with electron platform? or have any alternative?

timbru31
timbru31 requested changes Dec 16, 2020
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to have this PR properly reviewed and merged both the conflicts have to be resolved and the changes in plugin.xml and package.json need to be reverted.

@zorn-v
Copy link

zorn-v commented Dec 17, 2020 •
edited
Loading

@capc0
Try this #371 (comment)

@zorn-v
Copy link

zorn-v commented Dec 19, 2020

This PR will not needed if #371 merged

@erisu erisu mentioned this pull request Dec 23, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbru31 timbru31 timbru31 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohitagre @zorn-v @capc0 @timbru31 @Jammer99