Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: removed old platform code & lint cleanup #519

Merged
merged 7 commits into from
Mar 30, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 30, 2022

Platforms affected

windows8, windowsphone, blackberry, amazon-fireos

Motivation and Context

The above platforms has been deprecated and no longer supported for a long time.

Description

This PR removed the residual old platform code & also applied lint corrections.

Testing

  • not available as the old platform core code was not exisiting.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@erisu erisu merged commit f85373b into apache:master Mar 30, 2022
@erisu erisu deleted the chore/cleanup branch March 30, 2022 08:06
pmcquay pushed a commit to BetterImpact/cordova-plugin-file that referenced this pull request Sep 2, 2022
* style: apply lint fix
* test: remove old windows related platform code
* test: remove old blackberry related platform code
* test: remove old amazon-fireos related platform code
* style: remove eslint-disable-line no-undef & add globals
* chore!: remove old windows8 code
* chore!: remove old windowsphone code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants