Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused private field and format java code #596

Closed
wants to merge 2 commits into from

Conversation

ath0mas
Copy link

@ath0mas ath0mas commented Aug 23, 2023

Platforms affected

Android

Motivation and Context

Remove private field permissions never used.

Description

  • removed unused permissions
  • java code format by the IDE (IntelliJ IDEA / Android Studio)

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu
Copy link
Member

erisu commented Oct 17, 2023

I just noticed this PR after I have already merged in my PR that practically did the same things.
#607

I will go ahead and close out this PR as completed.
Sorry about that. :(

@erisu erisu closed this Oct 17, 2023
@ath0mas ath0mas deleted the permissions-and-code-format branch December 24, 2023 16:21
@ath0mas ath0mas mentioned this pull request Dec 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants