feat(android): Download event #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#1020 should fix any failing tests |
breautek
force-pushed
the
download-event
branch
from
4a440a9 to
92d1014
Compare
|
Merging because this is simply a rebase of #743 which already has 👍 votes. Chrome tests is failing is not related to this PR. |
pesi-hgc
pushed a commit
to pesi-hgc/cordova-plugin-inappbrowser-transparent
that referenced
this pull request
Nov 3, 2023
* feat(android): Added download event * android typos, whitespaces and whiteline corrected * Update README.md * fix: removed added whitespace trail --------- Co-authored-by: Shaikh Amaan FM <thisisamaan.s@gmail.com> Co-authored-by: Shaikh Amaan FM <53618794+shaikh-amaan-fm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Adds download event
Rebase of version of #743
closes #743
closes #311
This PR fixes a merge conflict that the original PR had, as well as lint issues.
Description
Testing
Ran
npm testRan cordova-paramedic manually for android API 33.
Ran a manual test and observed the download event coming through for download links.
Checklist
(platform)if this change only applies to one platform (e.g.(android))