Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1022 android: enable zoom without on-screen controls #1023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reznej
Copy link

@reznej reznej commented Sep 20, 2023

Platforms affected

Android

Motivation and Context

Closes Issue #1022

Description

This change adds an settable option zoomcontrols in addition to zoom at initialisation of the Inappbrowser instance. This enables a separation between zoom-controls (pinch-to-zoom) and additionally showing zoom-buttons to manually adjust zooming.

Testing

Ran manual tests with different combinations for parameters zoom and zoomcontrols.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant