Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CB-14234: (ios) Don't call handleOpenURL for system URLs #278

Merged
merged 1 commit into from
Aug 22, 2018
Merged

CB-14234: (ios) Don't call handleOpenURL for system URLs #278

merged 1 commit into from
Aug 22, 2018

Commits on Aug 22, 2018

  1. CB-14234: Don't call handleOpenURL for system URLs 

    When calling `.open()` with a target of `_system`, the InAppBrowser on iOS is both launching the URL in the system browser AND also broadcasting to open the URL within the app (calling handleOpenURL). The latter behavior is problematic in many circumstances (e.g. when you want to explicitly open a link in a browser which is a universal link handled by the app).

This commit attempts to address this by checking the return value from openURL -- if it does not open the URL successfully, then (and only then) the code falls back to broadcasting the event within the app to handleOpenURL.
    @dpolivy
    dpolivy committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    4215b9d View commit details
    Browse the repository at this point in the history