[android] Prevent malformed callbackId from reaching app cordova view #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Certain poorly formed callbackId(s) could be used to execute js code in the context of the cordova app.
Description
Uses a regex check to make sure the callbackId requested matches the pattern. This is the same pattern matching code that is already used in iOS.
Testing
Manually tested.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)