Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(android) Code improve #524

Merged
merged 1 commit into from
Dec 30, 2019
Merged

(android) Code improve #524

merged 1 commit into from
Dec 30, 2019

Conversation

flexaddicted
Copy link
Contributor

Improve code formatting

Platforms affected

Android

Motivation and Context

The change is required to improve Java code.

Description

The change introduce the following changes:

  • Replace the beforeload string with BEFORELOAD constant
  • Add spaces curly braces

Testing

I've checked the changes in a sample app.

Checklist

  • [] I've run the tests to see all new and existing tests pass
  • [] I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • [] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • [] I've updated the documentation if necessary

Improve code formatting
@NiklasMerz NiklasMerz added this to the 3.2.0 milestone Dec 30, 2019
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Since this is only code style, it should be fine?

Restarted tests and passed, quick manual test with https://github.com/dpa99c/cordova-plugin-inappbrowser-test on Android emulator was successful.

@NiklasMerz NiklasMerz requested a review from erisu December 30, 2019 00:33
@flexaddicted
Copy link
Contributor Author

flexaddicted commented Dec 30, 2019

Code looks good to me. Since this is only code style, it should be fine?

Restarted tests and passed, quick manual test with https://github.com/dpa99c/cordova-plugin-inappbrowser-test on Android emulator was successful.

I've also replaced "beforeload" string with BEFORELOAD constant. @NiklasMerz @erisu

@NiklasMerz
Copy link
Member

@flexaddicted Thank you for your PR. I think this is a good change.

I would like to get one other review before merging this.

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiklasMerz NiklasMerz merged commit 416b05c into apache:master Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants