Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(iOS) fixing problem status bar frame too narrow #638

Closed
wants to merge 1 commit into from

Conversation

kutoman
Copy link

@kutoman kutoman commented Mar 4, 2020

this approach considers the safe area insets

Platforms affected

iOS

Motivation and Context

This change prevents from hardcoding the status bar frame size.
It doesn't really fix any open issue as far as I could see.

Description

the status bar frame was too narrow so that some symbols of the iPhone XR statusbar weren't
contained by the frame fully.

Testing

tested it in iPhone 8 and iPhone XR simulators

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

this approach considers the safe area insets
@timbru31
Copy link
Member

The CI failure was unrelated, I've restarted the affected build and now it's green.

@kutoman
Copy link
Author

kutoman commented Mar 18, 2020

#546 handles the same issue differently

@mosabab
Copy link
Contributor

mosabab commented Mar 26, 2020

I test it but this need to some modifications.

Anyway you can close your pull request because someone made a well tested pull request that will be merged to master in the future:
#546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants