fix(ios): prevent statusbar rotation after closing InAppBrowser

[jcesarmobile]

Platforms affected

ios

Motivation and Context

closes #623

Description

according to the stackoverflow link, setting the tmpWindow to hidden should release it and the regular window would take control, but it's not being released and that causes the statusbar to rotate (because the tmpController can rotate to any direction).
Setting the tmpWindow to nil releases it and the original window takes control and fixes the issue.

Testing

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[timbru31]

Do we need to set the tmpWindow to nil in the hide method, too?
This change should be backwards compatible, shouldn't it?

[jcesarmobile]

not really sure what's the difference between hide and close, but if hide is supposed to not destroy the IAB, then probably shouldn't be done there as it might destroy the IAB session too, but didn't try

[jeirasmus]

@jcesarmobile

Nice fix, but not fully working at least with our application. If you close the inappbrowser in landscape mode and application under it returns to be in fixed portrait mode, view (UI is has moved) is a little bit higher after that. If you keep device on portrait all the time, that does not happen.

It is easy to see if you have navigation bar on top of your UI and you can see it to be more narrow.

[jcesarmobile]

That’s a different problem

[jcesarmobile]

@timbru31, I tested and the rotation was happening when using hide, so I've set it to nil on hide too.
Setting the window to nil doesn't affect the IAB VC, if you call show later it keeps showing last page it was showing before calling hide (meaning, IAB VC doesn't get destroyed, only the tmpWindow, and the tmpWindow gets recreated on show method).

[NiklasMerz]

I did some quick tests and it looks good to me.