Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update install engines #685

Merged
merged 3 commits into from
Jun 4, 2020
Merged

chore: update install engines #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
926dce5
chore: update install engines
jcesarmobile Apr 27, 2020
f768a08
Update package.json
jcesarmobile May 14, 2020
2d30473
Update plugin.xml
jcesarmobile May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@
"cordova": ">=3.1.0"
},
"4.0.0": {
"cordova": ">=3.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think minimum Cordova version should be increased as well, both here and in plugin.xml. I don't think we want to keep supporting old Cordova versions:)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://lists.apache.org/thread.html/rc277f523ceb625820acd4b361e08b3b0269108f19a4d5e85b9d104fd%40%3Cdev.cordova.apache.org%3E

"cordova-ios": ">=4.0.0"
},
"5.0.0": {
"cordova": ">100"
}
}
Expand Down
1 change: 1 addition & 0 deletions plugin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@

<engines>
<engine name="cordova" version=">=3.1.0" /><!-- Needs cordova/urlutil -->
<engine name="cordova-ios" version=">=4.0.0" />
</engines>

<!-- android -->
Expand Down