(ios): allow to set "preferredContentMode"

[NiklasMerz]

Platforms affected

ios

Motivation and Context

Closes #687

Description

WIP to show what issue is talking about. See #687

Testing

Checklist

• I've run the tests to see all new and existing tests pass
• I added automated test coverage as appropriate for this change
• Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
• If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
• I've updated the documentation if necessary

[jcesarmobile]

I've commented on the issue, it should be a preference or browser option, not default, because showing a browser user agent is an iPadOS feature, we can just disable it for everybody.

[NiklasMerz]

I think preference totally makes sense and using this preference for the main webview, too. Changed this ways. Let me know what you think.

[dpa99c]

The actual functionality works fine but I think we want to document it in the README.md so we don't end up with undocumented functionality.

Maybe a "Preferences" subsection under Installation which indicates the end user were the preference needs to live in config.xml and an example usage, e.g.

<preference name="PreferredContentMode" value="mobile" />

Also need to indicate that this preference is platform-specific to iOS.

[NiklasMerz]

@dpa99c Thanks for the review. Yes we need to document. Since we also would need that preference in the cordova-ios platform my plan was to do the documentation in cordova-docs where the other prefrences are. The PR for cordova-ios is to be done, too.

[jcesarmobile]

I agree with dpa99c, the preference is also going to work on ios and should be documented on ionic-docs for ios, but since it also works in the plugin, should be mentioned in the plugin too

[NiklasMerz]

It makes sense to explain this a bit. I pushed an update for README.

[NiklasMerz]

Tests are failing probably because CI uses Xcode 10 and this is new for iOS13 in Xcode 11.

[timbru31]

Travis is still not happy. Otherwise thank & LGTM

[timbru31]

Talking about the Travis failure (https://travis-ci.org/github/apache/cordova-plugin-inappbrowser/jobs/694970579): Did the name change from iPhone-XR to
{ platform:iOS Simulator, id:4715F3CB-93A5-46AB-AAEA-D2E86B57C88B, OS:12.1, name:iPhone Xʀ }? (Around line 1698)

[NiklasMerz]

I dont really know where iPhone-XR comes from. I will try different platforms..

[jcesarmobile]

I think travis changes should go outside of this PR, probably best to sent a separate PR and once the tests are good in that PR, merge it and rebase this one

[erisu]

@timbru31 https://github.com/ios-control/ios-sim/blob/7624cc7af7e875a04f2f7dc3d5c78f2979eb9908/src/helpers.js#L88-L92

and iPhone-XR comes from here.

https://github.com/apache/cordova-paramedic/blob/dbdbdc379067b8b3450f1008a9922b91f254fa73/conf/pr/local/ios-10.0.config.json#L5

Which is used because of - env: PLATFORM=local/ios-10.0

[erisu]

@NiklasMerz the change in CI configurations might fail because it does not exist in paramedic

- env: PLATFORM=local/ios-13.0

https://github.com/apache/cordova-paramedic/tree/master/conf/pr/local

[NiklasMerz]

@NiklasMerz the change in CI configurations might fail because it does not exist in paramedic

- env: PLATFORM=local/ios-13.0

https://github.com/apache/cordova-paramedic/tree/master/conf/pr/local

It did fail https://travis-ci.org/github/apache/cordova-plugin-inappbrowser/jobs/694985529. I reverted that.

[NiklasMerz]

Looks like I cannot use the Xcode 11 image with this local configuration. paramedic needs to be fixed first.

[NiklasMerz]

Is this good to merge? Failing CI is a seperate issue being worked on.

[timbru31]

two minor bits, otherwise LGTM and I think we can merge