-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): add InAppBrowserStatusBarStyle 'darkcontent' configuration option #828
Conversation
Co-authored-by: Tim Brust <github@timbrust.de>
We should be careful with the For this PR is not a big deal since we are planning a major release and can bump the engines to cordova-ios 6 instead of 5.1.0 as on my pending PR, but then noticed version 4.1.0 is already using I've reported the issue |
… option (apache#828) Co-authored-by: Tim Brust <github@timbrust.de>
… option (apache#828) Co-authored-by: Tim Brust <github@timbrust.de>
… option (apache#828) Co-authored-by: Tim Brust <github@timbrust.de>
… option (apache#828) Co-authored-by: Tim Brust <github@timbrust.de>
… option (apache#828) Co-authored-by: Tim Brust <github@timbrust.de>
Platforms affected
iOS
Motivation and Context
If the IAB loads a page with a white background on a device with dark mode enabled the statusbar will be white with white content. This PR ads the config.xml to set statusbar content to dark to make it readable again for pages like this.
Description
#765 added the option to set the statusbar to light content. iOS 13 introduced a new dark content option and this PR adds that.
Testing
Manual test
No automatic tests
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)