-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(android) Fix for webView window not being destroyed correctly causing memory leak (bug #290) #882
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGT
Thanks for contributing
When will the full version with these fixes be released? |
|
||
// Fix for webView window not being destroyed correctly causing memory leak | ||
// (https://github.com/apache/cordova-plugin-inappbrowser/issues/290) | ||
if (url.equals(new String("about:blank"))) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call to new String()
is unnecessary, consider doing: if (url.equals("about:blank")) {
When will the next version with these fixes be released? |
Hi @NiklasMerz, when will |
Platforms affected
android
Motivation and Context
This PR fixes #290
Description
A fix for the issue reported in #290 is suggested in the same. I created this pull request after implementing the fix in my own forked repo and verifying it works as intended in Android.
Testing
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)