(ios) Fixes #566 #914
Open
(ios) Fixes #566 #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents closing pagesheet by swiping down, which led to unresponsive app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
Fixes #566 by setting modalInPopover to true, disabling the swipe to dismiss feature.
Description
Sets modalInPopover to true, only allowing closing by "Done" button
Testing
Created a pagesheet inAppBrowser and tried to close by swiping down. Got the unresponsive app as described in the bug report. Added my changed, rebuild and tried the same. The inAppBrowser is no longer closed, unless "Done" is pressed.
Checklist
(platform)if this change only applies to one platform (e.g.(android))