Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): increase toolbar to 48dp #946

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

erisu
Copy link
Member

@erisu erisu commented May 18, 2022

Platforms affected

  • android

Motivation and Context

Follow the Material Design Guidelines for touch targets size requirements.

"For most platforms, consider making touch targets at least 48 x 48dp."

https://m3.material.io/foundations/accessible-design/accessibility-basics

Google Play will report a warning that the close button does not meet the requirement.

Description

  • The current close button size is 58dp width, 44dp height.
  • This PR increases the toolbar area space to 48dp, which in effect increases the close button to 48dp.

Testing

  • build app and confirm increase height.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

Material Design Guidelines says "For most platforms, consider making touch targets at least 48 x 48dp."
@erisu erisu requested review from NiklasMerz and breautek May 18, 2022 10:03
@erisu erisu merged commit dfcffb4 into apache:master Jul 12, 2022
@erisu erisu deleted the fix/google-play-tap-target-size branch July 12, 2022 12:17
pesi-hgc pushed a commit to pesi-hgc/cordova-plugin-inappbrowser-transparent that referenced this pull request Nov 3, 2023
Material Design Guidelines says "For most platforms, consider making touch targets at least 48 x 48dp."
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants