Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update typings #78

Merged
merged 1 commit into from
Feb 19, 2019
Merged

feat: update typings #78

merged 1 commit into from
Feb 19, 2019

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Feb 18, 2019

This is part of apache/cordova#39

Platforms affected

n/a - development with TypeScript

Motivation and Context

updates typings as discussed in apache/cordova#39

Description

Updates types to correctly use TSDoc format

Testing

Manual testing via development in VSCode.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31
Copy link
Member Author

@janpio - a small fix of #75, the comment is now correct TSDoc which could be parsed/rendered (try it here: https://microsoft.github.io/tsdoc/)

@janpio janpio merged commit 73b96e4 into apache:master Feb 19, 2019
@timbru31 timbru31 deleted the feat/update-typings branch April 10, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants