Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Spec cleanup and fixes #366

Merged
merged 4 commits into from
Oct 30, 2019
Merged

Spec cleanup and fixes #366

merged 4 commits into from
Oct 30, 2019

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Part of apache/cordova#169

Description

  • Merge duplicated tests in package.spec into one
  • Don't use done for synchronous tests
  • Let Jasmine handle promises in tests
  • fix: return unhandled promises in spec

@raphinesse raphinesse added this to the 7.0.1 milestone Oct 30, 2019
@raphinesse raphinesse mentioned this pull request Oct 30, 2019
Closed
17 tasks
@raphinesse raphinesse merged commit c1df7df into apache:master Oct 30, 2019
@raphinesse raphinesse deleted the spec-cleanup-and-fixes branch October 30, 2019 14:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erisu erisu erisu approved these changes

@janpio janpio Awaiting requested review from janpio

@timbru31 timbru31 Awaiting requested review from timbru31

@breautek breautek Awaiting requested review from breautek

Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
7.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@raphinesse @erisu