Don't require auth on login attempts #2321
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Previously with require_valid_user=true configured a user would need to supply Basic auth credentials in order to login via the _session endpoint (or have some otgher Catch-22 way of using an existing session). This patch makes it so that any attempt to POST to _session is allowed to proceed.
Testing recommendations
Try to POST to
_session
withrequire_valid_user = true
and don't supply any additional basic auth header. Without this patch you would get rejected.Related Issues or Pull Requests
Closes #1947.
Checklist
rel/overlay/etc/default.ini