Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vscode release 1.3.1 #120

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix vscode release 1.3.1 #120

merged 1 commit into from
Sep 12, 2023

Conversation

shanedell
Copy link
Contributor

@stevedlawrence My apologies, I didn't realize for each RC the release attribute was supposed to match that RC number. Will make sure to do this in the future.

@shanedell shanedell self-assigned this Sep 12, 2023
@shanedell shanedell merged commit 6e023af into apache:main Sep 12, 2023
1 check passed
@shanedell shanedell deleted the fix-vscode-1.3.1-release branch September 12, 2023 16:24
stevedlawrence
stevedlawrence reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@stevedlawrence stevedlawrence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. No worries, I forgot and I was was the one that made the commit to change release from a boolean to a sring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedlawrence stevedlawrence stevedlawrence left review comments

Assignees

@shanedell shanedell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shanedell @stevedlawrence