chore: update datafusion to 52#1394
Conversation
2b1423b to
8a7460c
Compare
milenkovicm
left a comment
There was a problem hiding this comment.
Looks like test failures should be fixable.
Please update ballista versions to 52 as well
Thanks @killzoner
Hey, i will have a look soon at the failing tests. I need to take a look at |
|
add file name to written |
51d64d7 to
7a7c8d7
Compare
ccc4f30 to
c239e64
Compare
|
@sqlbenchmark run tpch |
Ballista TPC-H Benchmark ResultsPR: #1394 - chore: update ballista crates to 52 Query Comparison
Total: Main=25808.80ms, PR=25713.00ms (-0.4%) Automated benchmark run by dfbench |
|
I suggest keeping this PR open for a bit more, as there is datafusion 51.1 in release process |
milenkovicm
left a comment
There was a problem hiding this comment.
thanks @killzoner
once 51.1 is released we can merge this
I'm fixing the conflict and we're good then I think |
8a63449 to
0940d00
Compare
0940d00 to
07d6c58
Compare
|
correction, once 52.1 is released |
|
thanks @killzoner |
|
@sqlbenchmark run tpch -s 10 -i 3 |
Ballista TPC-H Benchmark ResultsPR: #1394 - update to latest df 52.1 Query Comparison
Total: Main=62829.30ms, PR=62556.10ms (-0.4%) Automated benchmark run by dfbench |
Which issue does this PR close?
Closes #1357
Rationale for this change
Datafusion upgrade changes: https://datafusion.apache.org/library-user-guide/upgrading.html#datafusion-52-0-0
What changes are included in this PR?
CoalesceBatchesExecreferencesAre there any user-facing changes?
No