feat: disable DataFrame.cache() for ballista#1420
Draft
killzoner wants to merge 2 commits intoapache:mainfrom
Draft
feat: disable DataFrame.cache() for ballista#1420killzoner wants to merge 2 commits intoapache:mainfrom
killzoner wants to merge 2 commits intoapache:mainfrom
Conversation
killzoner
commented
Jan 28, 2026
milenkovicm
reviewed
Jan 28, 2026
Contributor
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
thanks @killzoner
I have one suggestion
Contributor
|
no need to implement anything on scheduler side at the moment |
killzoner
force-pushed
the
issue-1395
branch
2 times, most recently
from
78008ce to
de7d76c
Compare
killzoner
force-pushed
the
issue-1395
branch
2 times, most recently
from
2438a87 to
7d48acc
Compare
Contributor
|
You need to serialise logical plan extension, showcase project https://github.com/milenkovicm/ballista_extensions |
Contributor
Author
Thanks, I was looking at this part and I was not sure I needed to update ballista proto, this gives more context 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1395 (partially if we want to expand on future configurable cache later).
Rationale for this change
Disable explicitly
cache()method with good user level error rather than relying on currentpanicWhat changes are included in this PR?
Add cache factory to properly error the unsupported feature (links to apache/datafusion#18893)
Are there any user-facing changes?
User level error instead of panic