address comments

apache · Feb 19, 2024 · 1e69521 · 1e69521
1 parent bbc028c
commit 1e69521
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/.github/actions/setup-builder/action.yaml b/.github/actions/setup-builder/action.yaml
@@ -38,6 +38,8 @@ runs:
     - name: Install JDK ${{inputs.jdk-version}}
       uses: actions/setup-java@v4
       with:
+        # distribution is chosen to be zulu as it still offers JDK 8 with Silicon support, which
+        # is not available in the adopt distribution
         distribution: 'zulu'
         java-version: ${{inputs.jdk-version}}
 

diff --git a/.github/actions/setup-macos-builder/action.yaml b/.github/actions/setup-macos-builder/action.yaml
@@ -53,6 +53,8 @@ runs:
     - name: Install JDK ${{inputs.jdk-version}}
       uses: actions/setup-java@v4
       with:
+        # distribution is chosen to be zulu as it still offers JDK 8 with Silicon support, which
+        # is not available in the adopt distribution
         distribution: 'zulu'
         java-version: ${{inputs.jdk-version}}
         architecture: ${{inputs.jdk-architecture}}