Skip to content

Investigate Guava duplicated classes #1968

@kazuyukitanimura

Description

@kazuyukitanimura

Describe the bug

We now have duplicated classes that we ignore

                    <dependency>
                       <groupId>com.google.guava</groupId>
                       <artifactId>guava</artifactId>
                       <ignoreClasses>
                         <ignoreClass>com.google.thirdparty.publicsuffix.TrieParser</ignoreClass>
                         <ignoreClass>com.google.thirdparty.publicsuffix.PublicSuffixPatterns</ignoreClass>
                         <ignoreClass>com.google.thirdparty.publicsuffix.PublicSuffixType</ignoreClass>
                       </ignoreClasses>
                     </dependency>

Steps to reproduce

Without ignoring, we get

[ERROR] Rule 2: org.codehaus.mojo.extraenforcer.dependencies.BanDuplicateClasses failed with message:
[ERROR] Duplicate classes found:
[ERROR] 
[ERROR]   Found in:
[ERROR]     org.apache.spark:spark-network-common_2.13:jar:4.0.0:provided
[ERROR]     com.google.guava:guava:jar:33.2.1-jre:compile
[ERROR]   Duplicate classes:
[ERROR]     com/google/thirdparty/publicsuffix/TrieParser.class
[ERROR]     com/google/thirdparty/publicsuffix/PublicSuffixPatterns.class
[ERROR]     com/google/thirdparty/publicsuffix/PublicSuffixType.class

Expected behavior

We should not ignore this and exclude properly

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions