-
Notifications
You must be signed in to change notification settings - Fork 253
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
while setting the connection to S3 in (native/core/src/parquet/objectstore/s3.rs)
a mistake is being made in calculating virtual_hosted_style_request
which causes the connection to use a combination of path style and virtual hosted style.
virtual_hosted_style_request = path_style.to_lowercase() == "true";
s3_configs.insert(
AmazonS3ConfigKey::VirtualHostedStyleRequest,
virtual_hosted_style_request.to_string(),
);
if virtual_hosted_style_request {
if endpoint.ends_with("/") {
Some(format!("{endpoint}{bucket}"))
} else {
Some(format!("{endpoint}/{bucket}"))
}
} else {
Some(endpoint) // Avoid extra to_string() call since endpoint is already a String
}
Steps to reproduce
No response
Expected behavior
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working