Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of TPC-H q16 #569

Closed
andygrove opened this issue Jun 14, 2024 · 3 comments
Closed

Improve performance of TPC-H q16 #569

andygrove opened this issue Jun 14, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

andygrove commented Jun 14, 2024

What is the problem the feature request solves?

Comet is currently slower than Spark for TPC-H q16.

This query does not run fully native yet.

Issues

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added the enhancement New feature or request label Jun 14, 2024
@andygrove
Copy link
Member Author

andygrove commented Jun 14, 2024

As an experiment, I removed our check where we fall back to Spark for BuildRight with LeftAnti so that the query runs natively (possibly with incorrect results) and performance increased significantly and matched Spark (but was not faster). I no longer saw the "BroadcastExchange is not supported" error.

@andygrove
Copy link
Member Author

At the end of the query we are performing a RowToColumnar to move to Comet just for a query stage that performs a sort and then perform a ColumnarToRow. This likely explains why we currently make the query slower than Spark.

image

@andygrove
Copy link
Member Author

This issue is largely out of date, and current issues are noted in #391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant