Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid transition to Comet in some cases if the overhead of R2C and C2R outweighs the benefit #571

Open
andygrove opened this issue Jun 14, 2024 · 0 comments
Labels
enhancement New feature or request performance

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

Comet is currently slower than Spark for q16 because we transition to Comet at the end of the query just for a Sort operation and there is quite a lot of overhead of the surrounding R2C and C2R transitions (see #569 (comment) for more details).

We could implement a cost-based optimizer to avoid this. We could start off with some simple heuristics, such as "don't move to Comet just to do a sort" and then expand this into a true CBO with a cost model, although it is difficult to build an accurate cost model without statistics.

Describe the potential solution

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant