feat: Record Arrow FFI metrics #1128
Draft
+92
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
force-pushed
the
arrow-ffi-metric
branch
from
db42583
to
1715b5f
Compare
This was referenced Dec 1, 2024
andygrove
commented
Dec 2, 2024
| @@ -88,6 +90,7 @@ impl ScanExec { | |||
| ) -> Result<Self, CometError> { | |||
| let metrics_set = ExecutionPlanMetricsSet::default(); | |||
| let baseline_metrics = BaselineMetrics::new(&metrics_set, 0); | |||
| let arrow_ffi_time = MetricBuilder::new(&metrics_set).subset_time("arrow_ffi_time", 0); | |||
There was a problem hiding this comment.
I see now that this isn't just FFI time. It is the cost of calling CometBatchIterator.next() so includes the cost of that method getting the next input batch as well as the FFI export cost ...
There was a problem hiding this comment.
Moving this to draft for now while I think about this more
comphead
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
lgtm thanks @andygrove
one thing I'd like to mention are you planning to have it permanently or enable this internal metrics based on some spark key so as to spend resources on metrics only when its really needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
This is a subset of #1111, separated out to make reviews easier.
What changes are included in this PR?
Record time spent performing Arrow FFI to transfer batches between JVM and Rust code.
Note that these timings won't be fully exposed to Spark UI until we merge #1111.
How are these changes tested?