fix: [comet-parquet-exec] Fix regression in supported types #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
commented
Jan 19, 2025
| @@ -61,7 +61,7 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim | |||
| logWarning(s"Comet native execution is disabled due to: $reason") | |||
| } | |||
|
|
|||
| def supportedDataType(dt: DataType, allowStruct: Boolean = true): Boolean = dt match { | |||
| def supportedDataType(dt: DataType, allowStruct: Boolean = false): Boolean = dt match { | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## comet-parquet-exec #1309 +/- ##
=========================================================
- Coverage 56.07% 34.15% -21.92%
- Complexity 978 1009 +31
=========================================================
Files 119 122 +3
Lines 11735 47942 +36207
Branches 2251 10494 +8243
=========================================================
+ Hits 6580 16373 +9793
- Misses 4013 28295 +24282
- Partials 1142 3274 +2132 ☔ View full report in Codecov by Sentry. |
|
@mbutrovich @parthchandra another small fix |
andygrove
force-pushed
the
fix-regression-supported-types
branch
from
9ddf582 to
3a146d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Fix a regression that was causing a test failure in the TPC-DS correctness tests.
What changes are included in this PR?
How are these changes tested?